Improve error handling by not failing group rename step if a group was removed from account before reflecting it to workspace #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moved after getting it and before reflecting to the workspace
mwojtyczka
temporarily deployed
to
account-admin
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
- Coverage 81.70% 81.69% -0.02%
==========================================
Files 39 39
Lines 4390 4393 +3
Branches 815 816 +1
==========================================
+ Hits 3587 3589 +2
Misses 596 596
- Partials 207 208 +1 ☔ View full report in Codecov by Sentry. |
william-conti
suggested changes
Jan 8, 2024
mwojtyczka
had a problem deploying
to
account-admin
GitHub Actions
Failure
william-conti
approved these changes
Jan 8, 2024
mwojtyczka
temporarily deployed
to
account-admin
GitHub Actions
Inactive
mwojtyczka
changed the title
nfx
approved these changes
Jan 8, 2024
mwojtyczka
temporarily deployed
to
account-admin
GitHub Actions
Inactive
nfx
added a commit
that referenced
this pull request
Jan 12, 2024
* Added assessment step to estimate the size of DBFS root tables ([#741](#741)). * Added `TableMapping` functionality to table migrate ([#752](#752)). * Added `databricks labs ucx move` command to move tables and schemas between catalogs ([#756](#756)). * Added functionality to determine migration method based on DBFS Root ([#759](#759)). * Added `get_tables_to_migrate` functionality in the mapping module ([#755](#755)). * Added retry and rate limit to rename workspace group operation and corrected rate limit for reflecting account groups to workspace ([#751](#751)). * Adopted `databricks-labs-blueprint` library for common utilities to be reused in the other projects ([#758](#758)). * Converted `RuntimeBackend` query executions exceptions to SDK exceptions ([#769](#769)). * Fixed issue with missing users and temp groups after workspace-local groups migration and skip table when crawling table size if it does not exist anymore ([#770](#770)). * Improved error handling by not failing group rename step if a group was removed from account before reflecting it to workspace ([#762](#762)). * Improved error message inference from failed workflow runs ([#753](#753)). * Moved `TablesMigrate` to a separate module ([#747](#747)). * Reorganized assessment dashboard to increase readability ([#738](#738)). * Updated databricks-sdk requirement from ~=0.16.0 to ~=0.17.0 ([#773](#773)). * Verify metastore exists in current workspace ([#735](#735)).
Merged
nfx
added a commit
that referenced
this pull request
Jan 12, 2024
* Added assessment step to estimate the size of DBFS root tables ([#741](#741)). * Added `TableMapping` functionality to table migrate ([#752](#752)). * Added `databricks labs ucx move` command to move tables and schemas between catalogs ([#756](#756)). * Added functionality to determine migration method based on DBFS Root ([#759](#759)). * Added `get_tables_to_migrate` functionality in the mapping module ([#755](#755)). * Added retry and rate limit to rename workspace group operation and corrected rate limit for reflecting account groups to workspace ([#751](#751)). * Adopted `databricks-labs-blueprint` library for common utilities to be reused in the other projects ([#758](#758)). * Converted `RuntimeBackend` query executions exceptions to SDK exceptions ([#769](#769)). * Fixed issue with missing users and temp groups after workspace-local groups migration and skip table when crawling table size if it does not exist anymore ([#770](#770)). * Improved error handling by not failing group rename step if a group was removed from account before reflecting it to workspace ([#762](#762)). * Improved error message inference from failed workflow runs ([#753](#753)). * Moved `TablesMigrate` to a separate module ([#747](#747)). * Reorganized assessment dashboard to increase readability ([#738](#738)). * Updated databricks-sdk requirement from ~=0.16.0 to ~=0.17.0 ([#773](#773)). * Verify metastore exists in current workspace ([#735](#735)).
FastLee
pushed a commit
that referenced
this pull request
Jan 19, 2024
…s removed from account before reflecting it to workspace (#762) Fixes #761 In rare cases, it can happen that a group is removed from the account before we manage to reflect it in the workspace. It's usually a couple of minutes between listing the groups and reflecting it. This PR will log such cases without failing the tool. --------- Co-authored-by: Serge Smertin <259697+nfx@users.noreply.github.com>
FastLee
pushed a commit
that referenced
this pull request
Jan 19, 2024
* Added assessment step to estimate the size of DBFS root tables ([#741](#741)). * Added `TableMapping` functionality to table migrate ([#752](#752)). * Added `databricks labs ucx move` command to move tables and schemas between catalogs ([#756](#756)). * Added functionality to determine migration method based on DBFS Root ([#759](#759)). * Added `get_tables_to_migrate` functionality in the mapping module ([#755](#755)). * Added retry and rate limit to rename workspace group operation and corrected rate limit for reflecting account groups to workspace ([#751](#751)). * Adopted `databricks-labs-blueprint` library for common utilities to be reused in the other projects ([#758](#758)). * Converted `RuntimeBackend` query executions exceptions to SDK exceptions ([#769](#769)). * Fixed issue with missing users and temp groups after workspace-local groups migration and skip table when crawling table size if it does not exist anymore ([#770](#770)). * Improved error handling by not failing group rename step if a group was removed from account before reflecting it to workspace ([#762](#762)). * Improved error message inference from failed workflow runs ([#753](#753)). * Moved `TablesMigrate` to a separate module ([#747](#747)). * Reorganized assessment dashboard to increase readability ([#738](#738)). * Updated databricks-sdk requirement from ~=0.16.0 to ~=0.17.0 ([#773](#773)). * Verify metastore exists in current workspace ([#735](#735)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare cases, it can happen that a group is removed from the account before we manage to reflect it in the workspace. It's usually a couple of minutes between listing the groups and reflecting it. This PR will log such cases without failing the tool.